GWphua commented on code in PR #18731:
URL: https://github.com/apache/druid/pull/18731#discussion_r2689369111
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ConcurrentGrouper.java:
##########
@@ -332,7 +332,7 @@ public void reset()
throw new ISE("Grouper is closed");
}
- groupers.forEach(Grouper::reset);
Review Comment:
You are correct, only SpillingGrouper's method is called here.
I changed this to make my life easier during development:
1. IntelliJ can jump to the SpillingGrouper method, instead of going to the
Grouper interface.
2. Future readers will be able to tell that the groupers object held by
`ConcurrentGrouper` will be `SpillingGrouper`s.
If the purpose is to keep the changes limited to this PR only connected to
the Groupby metrics, I will be opening a new PR. Let me know if you would
prefer that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
