kfaraz commented on code in PR #18968:
URL: https://github.com/apache/druid/pull/18968#discussion_r2762849696
##########
server/src/main/java/org/apache/druid/server/compaction/MostFragmentedIntervalFirstPolicy.java:
##########
@@ -185,8 +215,18 @@ public Eligibility checkEligibilityForCompaction(
"Average size[%,d] of uncompacted segments in interval must be at
most [%,d]",
avgSegmentSize, maxAverageUncompactedBytesPerSegment.getBytes()
);
+ }
+
+ final double uncompactedBytesRatio = (double) uncompacted.getTotalBytes() /
+ (uncompacted.getTotalBytes() +
candidate.getCompactedStats().getTotalBytes());
+ if (uncompactedBytesRatio <
incrementalCompactionUncompactedBytesRatioThreshold) {
+ return Eligibility.incrementalCompaction(
Review Comment:
Let's not return `incrementalCompaction` here until incremental compaction
is actually implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
