cecemei commented on PR #18968: URL: https://github.com/apache/druid/pull/18968#issuecomment-3857643126
> Thanks for the PR, @cecemei ! > > I like the idea of separating the `CompactionStatus` (i.e. the current degree of compaction of an interval) from the `Eligibility` (i.e. whether an interval should be picked for compaction or not). > > I have left some suggestions to aid with the separation. Let me know if they make sense. I addressed most comments except for the coordinator based compaction and incremental compaction feature change. The major change is i moved a lot of CompactionStatus stuff to CompactionEligibility, and update the CHECK to return String (null for previous CompactionStatus.COMPLETE, and non-null for previous CompactionStatus.pending...), it seems simpler since after all we're just looking for a reason to do compaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
