kfaraz commented on code in PR #18968:
URL: https://github.com/apache/druid/pull/18968#discussion_r2767211242
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java:
##########
@@ -460,14 +462,27 @@ private static ClientCompactionTaskQuery compactSegments(
context.put("priority", compactionTaskPriority);
final String taskId = IdUtils.newTaskId(TASK_ID_PREFIX,
ClientCompactionTaskQuery.TYPE, dataSource, null);
+ final ClientCompactionIntervalSpec clientCompactionIntervalSpec;
+ Preconditions.checkArgument(entry.getPolicyEligibility() != null, "Must
have a policy eligibility");
+ switch (entry.getPolicyEligibility().getPolicyEligibility()) {
+ case FULL_COMPACTION:
+ clientCompactionIntervalSpec = new
ClientCompactionIntervalSpec(entry.getCompactionInterval(), null, null);
+ break;
+ case INCREMENTAL_COMPACTION:
Review Comment:
Please revert this change since we need not support incremental compaction
with Coordinator-based compaction duty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
