gianm commented on code in PR #19121:
URL: https://github.com/apache/druid/pull/19121#discussion_r2913531737
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -636,7 +636,7 @@ static Map<Interval, DataSchema>
createDataSchemasForIntervals(
toolbox.getEmitter(),
metricBuilder,
segmentProvider.dataSource,
- umbrellaInterval(timelineSegments, segmentProvider),
+ JodaUtils.umbrellaInterval(Iterables.transform(timelineSegments,
DataSegment::getInterval)),
Review Comment:
In https://github.com/apache/druid/issues/19117 there was talk about there
being problems when the `segmentGranularity` is `DAY`, job interval is a day,
but there are only a couple of `HOUR` segments existing. Do we have a test for
this case? If not can you please add one? I wanted to confirm that it's ok to
use the wider interval for the lock only, and the shorter interval for the data
schema, in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
