cecemei commented on code in PR #19121:
URL: https://github.com/apache/druid/pull/19121#discussion_r2914735566
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -636,7 +636,7 @@ static Map<Interval, DataSchema>
createDataSchemasForIntervals(
toolbox.getEmitter(),
metricBuilder,
segmentProvider.dataSource,
- umbrellaInterval(timelineSegments, segmentProvider),
+ JodaUtils.umbrellaInterval(Iterables.transform(timelineSegments,
DataSegment::getInterval)),
Review Comment:
This does mean that `CompactionState.UniformGranularitySpec.inputIntervals`
generated by native runner would be the umbrella interval for all existing
segments, while msq runner it'd be the input interval in
`CompactionTask.CompactionIOConfig.CompactionInputSpec.interval`. Updated all
test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
