github-advanced-security[bot] commented on code in PR #19121:
URL: https://github.com/apache/druid/pull/19121#discussion_r2914824641
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskRunBase.java:
##########
@@ -399,7 +442,7 @@
for (int i = 0; i < 3; i++) {
Interval interval =
Intervals.of("2014-01-01T0%d:00:00/2014-01-01T0%d:00:00", i, i + 1);
Assert.assertEquals(interval, segments.get(i).getInterval());
- Interval inputInterval = segmentGranularity == null ? interval :
this.inputInterval;
+ Interval inputInterval = segmentGranularity == null ? interval :
TEST_ACTUAL_INTERVAL;
Review Comment:
## Possible confusion of local and field
Confusing name: method [testRunCompactionTwiceWithSegmentLock](1) also
refers to field [inputInterval](2) (without qualifying it with 'this').
[Show more
details](https://github.com/apache/druid/security/code-scanning/10872)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskRunBase.java:
##########
@@ -1740,7 +1808,8 @@
for (int i = 0; i < 3; i++) {
Interval interval =
Intervals.of("2014-01-01T0%d:00:00/2014-01-01T0%d:00:00", i, i + 1);
Assert.assertEquals(interval, segments.get(i).getInterval());
- Interval inputInterval = gran == null ? interval : this.inputInterval;
+ // native runner use interval from actual seen segments, while msq
runner use never use this gran
+ Interval inputInterval = gran == null ? interval :
TEST_ACTUAL_INTERVAL;
Review Comment:
## Possible confusion of local and field
Confusing name: method [verifyCompactedSegment](1) also refers to field
[inputInterval](2) (without qualifying it with 'this').
[Show more
details](https://github.com/apache/druid/security/code-scanning/10873)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
