jaykanakiya commented on code in PR #19146:
URL: https://github.com/apache/druid/pull/19146#discussion_r2941792803
##########
processing/src/main/java/org/apache/druid/data/input/impl/StringDimensionSchema.java:
##########
@@ -40,15 +51,33 @@ public static StringDimensionSchema create(String name)
public StringDimensionSchema(
@JsonProperty("name") String name,
@JsonProperty("multiValueHandling") MultiValueHandling
multiValueHandling,
- @JsonProperty("createBitmapIndex") Boolean createBitmapIndex
+ @JsonProperty("createBitmapIndex") Boolean createBitmapIndex,
+ @JsonProperty("maxStringLength") @Nullable Integer maxStringLength
Review Comment:
Thanks for taking a look @clintropolis. Adding something like
`StringCommonFormatColumnFormatSpec` would make it cleaner and makes sense to
consolidate the configs there. Since it seems like a bigger refactor, does it
make sense to do it in a follow up? Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
