clintropolis commented on code in PR #19146:
URL: https://github.com/apache/druid/pull/19146#discussion_r2928335441
##########
processing/src/main/java/org/apache/druid/data/input/impl/StringDimensionSchema.java:
##########
@@ -40,15 +51,33 @@ public static StringDimensionSchema create(String name)
public StringDimensionSchema(
@JsonProperty("name") String name,
@JsonProperty("multiValueHandling") MultiValueHandling
multiValueHandling,
- @JsonProperty("createBitmapIndex") Boolean createBitmapIndex
+ @JsonProperty("createBitmapIndex") Boolean createBitmapIndex,
+ @JsonProperty("maxStringLength") @Nullable Integer maxStringLength
Review Comment:
drive by comment (i'll have a closer look at rest of PR later)
instead of adding additional arguments here, I was hoping to deprecate these
arguments in favor of adding a column format spec similar to was done for
auto/json columns in #17762, which could serve as a reference for how this
should be wired up. I was planning to move the existing `createBitmapIndex` and
`multiValueHandling` into such a spec, but just haven't got to it yet. I think
this would be much cleaner and less disruptive to call sites going forward. It
also allows wiring up to `IndexSpec` to be able to define job level defaults as
a middle place between per column and system wide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
