aho135 commented on code in PR #19146:
URL: https://github.com/apache/druid/pull/19146#discussion_r2956995565
##########
processing/src/main/java/org/apache/druid/guice/BuiltInTypesModule.java:
##########
@@ -89,6 +90,7 @@ public void configure(Binder binder)
public SideEffectRegisterer
initDimensionHandlerAndMvHandlingMode(DefaultColumnFormatConfig formatsConfig)
{
setStringMultiValueHandlingModeIfConfigured(formatsConfig.getStringMultiValueHandlingMode());
+ setMaxStringLengthIfConfigured(formatsConfig.getMaxStringLength());
Review Comment:
You can take a look at druid.indexing.formats.stringMultiValueHandlingMode
in
[BuiltInTypesModuleTest](https://github.com/apache/druid/blob/master/processing/src/test/java/org/apache/druid/guice/BuiltInTypesModuleTest.java#L105)
It would be good to have some test coverage for the new property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
