gianm commented on PR #19089: URL: https://github.com/apache/druid/pull/19089#issuecomment-4099316768
> @gianm updated. I think we should also make the default repo settings on PRs to do a merge and take the PR description (e.g. not just force a *-list of commit messages (which often aren't descriptive at all). By "do a merge" you mean "squash and merge"? I think that's already the default and IMO is best. I'm not sure how I feel about the default description. The problem with concatenating the commits is it can include a bunch of junk. The problem with using the PR description is they tend to be long, IMO too long to be good commit messages. I generally try to edit the commit message when I'm merging a PR. I think there's no way around manual edits being a good idea. Anyway, I'm sort of ambivalent about the default messages, as a result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
