jtuglu1 commented on PR #19089: URL: https://github.com/apache/druid/pull/19089#issuecomment-4099451323
> Btw, this PR should probably be `dev:`? It doesn't seem like a minor thing, as it will affect the dev workflow for everyone. To me `minor:` is for stuff like correcting spelling errors. And here we go with second-guessing the tags before they're even added 😄 Done. I think that difference is largely immaterial; what **does** matter is that we are now recording context inside the git tree, which makes it WAY easier to bisect for issues without digging through PR links. It also helps that GH release notes can be auto-generated from the conventional commit syntax (meaning you don't need to rely on users specifying Release Notes tag and instead do something like (fix!: blah) to know that it's a breaking change). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
