gianm commented on code in PR #19144:
URL: https://github.com/apache/druid/pull/19144#discussion_r2967927194
##########
multi-stage-query/src/main/java/org/apache/druid/msq/dart/guice/DartControllerModule.java:
##########
@@ -83,7 +83,7 @@ public static class ActualModule implements Module
public void configure(Binder binder)
{
JsonConfigProvider.bind(binder, DartModules.DART_PROPERTY_BASE +
".controller", DartControllerConfig.class);
- JsonConfigProvider.bind(binder, DartModules.DART_PROPERTY_BASE +
".query", DefaultQueryConfig.class, Dart.class);
+ JsonConfigProvider.bind(binder, DartModules.DART_PROPERTY_BASE +
".query", QueryConfigProvider.class, Dart.class);
Review Comment:
This can stay as `DefaultQueryConfig`, it really just is binding the local
config.
##########
multi-stage-query/src/main/java/org/apache/druid/msq/dart/controller/sql/DartSqlEngine.java:
##########
@@ -100,7 +100,7 @@ public DartSqlEngine(
DartQueryKitSpecFactory queryKitSpecFactory,
MultiQueryKit queryKit,
ServerConfig serverConfig,
- @Dart DefaultQueryConfig dartQueryConfig,
+ @Dart QueryConfigProvider queryConfigProvider,
Review Comment:
This can stay `@Dart DefaultQueryConfig`, it's a config for dart-specific
context keys, and is going to be additive to the stuff `QueryConfigProvider`
(which will be added elsewhere, and isn't needed here).
##########
services/src/main/java/org/apache/druid/guice/SegmentSchemaCacheModule.java:
##########
@@ -61,7 +61,7 @@ public void configure(Binder binder)
{
JsonConfigProvider.bind(binder, "druid.coordinator.segmentMetadata",
SegmentMetadataQueryConfig.class);
JsonConfigProvider.bind(binder, "druid.coordinator.query.scheduler",
QuerySchedulerProvider.class, Global.class);
- JsonConfigProvider.bind(binder, "druid.coordinator.query.default",
DefaultQueryConfig.class);
+ JsonConfigProvider.bind(binder, "druid.coordinator.query.default",
QueryConfigProvider.class);
Review Comment:
This can stay as `DefaultQueryConfig`, it really just is binding the local
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
