jtuglu1 commented on code in PR #19144:
URL: https://github.com/apache/druid/pull/19144#discussion_r2929803657
##########
server/src/main/java/org/apache/druid/client/BrokerViewOfBrokerConfig.java:
##########
@@ -21,34 +21,50 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.annotations.VisibleForTesting;
+import com.google.errorprone.annotations.concurrent.GuardedBy;
import com.google.inject.Inject;
import org.apache.druid.client.coordinator.Coordinator;
import org.apache.druid.client.coordinator.CoordinatorClient;
import org.apache.druid.client.coordinator.CoordinatorClientImpl;
import org.apache.druid.discovery.NodeRole;
import org.apache.druid.guice.annotations.EscalatedGlobal;
import org.apache.druid.guice.annotations.Json;
+import org.apache.druid.query.DefaultQueryConfig;
+import org.apache.druid.query.QueryContexts;
import org.apache.druid.rpc.ServiceClientFactory;
import org.apache.druid.rpc.ServiceLocator;
import org.apache.druid.rpc.StandardRetryPolicy;
import org.apache.druid.server.broker.BrokerDynamicConfig;
import javax.validation.constraints.NotNull;
+import java.util.Map;
/**
* Broker view of broker dynamic configuration.
*/
public class BrokerViewOfBrokerConfig extends
BaseBrokerViewOfConfig<BrokerDynamicConfig>
{
private final CoordinatorClient coordinatorClient;
+ private final DefaultQueryConfig defaultQueryConfig;
+
+ /**
+ * Pre-computed merge of {@link DefaultQueryConfig#getContext()} and
+ * {@link BrokerDynamicConfig#getQueryContext()}, recomputed on each config
sync.
+ * Dynamic config values override static defaults.
+ */
+ @GuardedBy("this")
+ private Map<String, Object> resolvedDefaultQueryContext;
Review Comment:
Yeah – meant to change this. Will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
