gianm commented on code in PR #19144:
URL: https://github.com/apache/druid/pull/19144#discussion_r2968020895
##########
multi-stage-query/src/main/java/org/apache/druid/msq/dart/controller/sql/DartSqlEngine.java:
##########
@@ -100,7 +100,7 @@ public DartSqlEngine(
DartQueryKitSpecFactory queryKitSpecFactory,
MultiQueryKit queryKit,
ServerConfig serverConfig,
- @Dart DefaultQueryConfig dartQueryConfig,
+ @Dart QueryConfigProvider queryConfigProvider,
Review Comment:
Sure, it can be a `@Dart QueryConfigProvider`. It should only look at the
static configuration for `@Dart DefaultQueryConfig` though. It shouldn't
incorporate the broker dynamic config. That will be added through the regular
`QueryConfigProvider`, which is applied to Dart queries as part of regular SQL
execution.
##########
multi-stage-query/src/main/java/org/apache/druid/msq/dart/controller/sql/DartSqlEngine.java:
##########
@@ -100,7 +100,7 @@ public DartSqlEngine(
DartQueryKitSpecFactory queryKitSpecFactory,
MultiQueryKit queryKit,
ServerConfig serverConfig,
- @Dart DefaultQueryConfig dartQueryConfig,
+ @Dart QueryConfigProvider queryConfigProvider,
Review Comment:
Sure, it can be a `@Dart QueryConfigProvider`. The implementation should
only look at the static configuration for `@Dart DefaultQueryConfig` though. It
shouldn't incorporate the broker dynamic config. That will be added through the
regular `QueryConfigProvider`, which is applied to Dart queries as part of
regular SQL execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
