kfaraz commented on code in PR #19179:
URL: https://github.com/apache/druid/pull/19179#discussion_r2958381474
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/OverlordCompactionResource.java:
##########
@@ -368,6 +372,16 @@ public Response simulateRunWithConfigUpdate(
).build();
}
+ @POST
+ @Path("/dryRun")
Review Comment:
The `/simulate` API is already meant to do a dry run. Please don't add
another API for the same purpose.
We should fix the existing simulate flow instead.
It is okay to break backward compatibility with the `/simulate` API since it
is not used anywhere being experimental and not documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
