kfaraz commented on code in PR #19179:
URL: https://github.com/apache/druid/pull/19179#discussion_r2959088083
##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/OverlordCompactionScheduler.java:
##########
@@ -370,45 +378,56 @@ private synchronized void scheduledRun()
}
/**
- * Creates and launches eligible compaction jobs.
+ * Creates a new compaction job queue and enqueues eligible jobs.
+ * In dry run mode, no jobs are launched and no metrics are emitted but
detailed stats are collected.
*/
- private synchronized void resetCompactionJobQueue()
+ private synchronized void resetCompactionJobQueue(
Review Comment:
Don't update this method. Instead, construct a separate
`CompactionJobQueue`, if needed in the simulate method. See
https://github.com/apache/druid/pull/19179#pullrequestreview-3973379513 for
details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
