kfaraz commented on code in PR #19179: URL: https://github.com/apache/druid/pull/19179#discussion_r2975676554
########## indexing-service/src/main/java/org/apache/druid/indexing/compact/CompactionJobParams.java: ########## @@ -35,6 +37,7 @@ public class CompactionJobParams private final DateTime scheduleStartTime; private final TimelineProvider timelineProvider; private final CompactionTaskStatusProvider compactionTaskStatusProvider; + private final CompactionStatusCollector compactionStatusCollector; Review Comment: We shouldn't need this. It seems very similar in role to the snapshot builder. We can keep track of the skipped/completed jobs in the snapshot builder itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
