kfaraz commented on code in PR #19772:
URL: https://github.com/apache/druid/pull/19772#discussion_r3727662566
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/config/DefaultTaskConfig.java:
##########
@@ -35,7 +36,15 @@
public class DefaultTaskConfig
{
@JsonProperty
- private final Map<String, Object> context = ImmutableMap.of();
+ private final Map<String, Object> context;
+
+ @JsonCreator
+ public DefaultTaskConfig(
Review Comment:
removed for now.
##########
docs/api-reference/data-management-api.md:
##########
@@ -35,15 +35,17 @@ For example, use `http://localhost:8888` for quickstart
deployments.
:::info
- Coordinator APIs for data management are now deprecated. Use new APIs served
by the Overlord instead.
-- Do not use these APIs while an indexing task or kill task is in progress for
the same datasource and interval.
+- The APIs to mark segments as used fail if an indexing task or kill task is
in progress for the same datasource and overlapping interval, to ensure that
there are no accidental data losses or data inconsistencies.
+- Do not use the APIs to mark segments as unused while an indexing task or
kill task is in progress for the same datasource and interval.
Review Comment:
locking changes removed from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
