FrankChen021 commented on PR #19875: URL: https://github.com/apache/druid/pull/19875#issuecomment-5207217341
Follow-up JUnit 5 cleanup evidence: - Removed the remaining JUnit 4, JUnit Vintage, and junit-jupiter-migrationsupport dependencies from the migrated extension modules. - Migrated the shared processing, SQL, and expression-test fixtures needed by Bloom and testing-tools away from JUnit 4 APIs; shared temp-directory helpers now use File/Druid temp-directory handling. - Dependency-tree audit of all ten migrated extensions found no junit:junit or other JUnit 4 dependency. org.hamcrest:hamcrest remains only in Bloom and testing-tools because the shared SQL test-jar still exposes Hamcrest matcher types; hamcrest-core was removed. - Validation: Bloom batch 8,806 tests passed with 0 failures/errors; testing-tools selected tests 8 passed with 0 failures/errors; Checkstyle 0 violations; SpotBugs 0 bugs/errors; dev/validate-junit5-usage reports all ten migrated extensions as JUnit 4-free. The repository-wide OpenRewrite JUnit 4 migration rule remains intentionally because processing, server, SQL, services, and other non-migrated modules still contain JUnit 4 tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
