FrankChen021 commented on PR #19875: URL: https://github.com/apache/druid/pull/19875#issuecomment-5210070236
Follow-up fix pushed as `b3c813f7d2530965788acc08940feb7072880ac7`. Changes: - Updated `processing/.../TempDirExtension.java` to use Druid `FileUtils.createTempDir/createTempDirInLocation`, `mkdirp`, and `deleteDirectory`; removed direct `java.nio.file.Files`, `File#mkdirs`, and Commons IO usage while preserving the extension lifecycle and checked-exception handling. - Fixed the migrated local matcher utility so `hasEntry(keyMatcher, valueMatcher)` retains Hamcrest-compatible matcher-valued semantics without adding Hamcrest. Validation: - `mvn -pl processing -am test -Dtest='org.apache.druid.error.ErrorResponseTest,org.apache.druid.indexer.report.TaskReportSerdeTest' -Dsurefire.failIfNoSpecifiedTests=false -DforkCount=0 -Pskip-static-checks -Dweb.console.skip=true`: PASS, 11 tests. - `mvn -pl processing -am test-compile -DskipTests -Dweb.console.skip=true -T1C`: PASS; checkstyle 0 violations and forbidden-API test scan 0 errors. - `mvn -pl processing -am spotbugs:check -DskipTests -Dweb.console.skip=true -T1C`: PASS; 0 bugs/errors. SpotBugs reported only the existing missing optional `MarkerManager` analysis class. - Changed-file audit found no JUnit4 or Hamcrest imports/dependencies. Cross-batch dependency evidence: - A reactor `test-compile` of server/MSQ against this branch reproduces compilation failures because unchanged server consumers still pass processing’s new local `DruidExceptionMatcher`/`ExceptionMatcher` to Hamcrest `MatcherAssert`; the MSQ SQL resource test has the same old Hamcrest assertion shape. - No `DruidExceptionAssertions` exists in current/master. The dedicated server migration batch already introduces `org.apache.druid.error.DruidExceptionAssertions` and `server.junit5.DruidExceptionMatcher`, while the dedicated MSQ batch moves its consumer to `msq.test` matchers. I therefore did not modify server/MSQ ownership or reintroduce JUnit4/Hamcrest here; those follow-up batches remain required for a complete full-reactor compile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
