FrankChen021 opened a new pull request, #19909: URL: https://github.com/apache/druid/pull/19909
## Summary - Migrate all JUnit 4 test imports and usages in `sql/**` and `quidem-ut/**` to JUnit 5. - Replace Hamcrest assertions and exception matchers with Jupiter assertions and the shared `DruidExceptionAssertions` fixture. - Make this SQL batch the sole owner of `BaseCalciteQueryTest`, `QueryTestRunner`, `SqlTestQueryStack`, and the migrated SQL fixture changes. - Remove unused JUnit 4, Vintage, and Hamcrest dependencies from `sql` and `quidem-ut`. `BaseCalciteQueryTest` no longer exposes Hamcrest `Matcher` or JUnit 4 types through its inherited test API. Exception verification now uses `DruidExceptionAssertions` and `Consumer<? super T>`, so the exact-count and extensions-core migrations can remove compatibility dependencies without retaining a legacy adapter in SQL. This batch is limited to `sql/**` and `quidem-ut/**`. It is the shared SQL prerequisite for [#19875](https://github.com/apache/druid/pull/19875) and [#19908](https://github.com/apache/druid/pull/19908); #19908 can stack on or follow this PR and owns only `extensions-contrib/**`. ## Validation - SQL tests: 5,465 passed, 0 failures/errors, 180 skipped. - SQL test-compile with Checkstyle, PMD, forbidden-API checks, and dependency enforcement: passed. - SQL SpotBugs: passed, 0 findings. - Quidem `LauncherSmokeTest`: 2/2 passed; filtered `QTest` (`kttm_Table`): 2/2 passed. - Exact-count downstream test-compile: passed. - `git diff --check` and scoped JUnit 4/Hamcrest source and POM audits: passed. The full `quidem-ut -am` reactor on current master currently stops in the separate MSQ test consumer because it still expects the old Hamcrest-returning `BaseCalciteQueryTest` API. This PR deliberately does not restore compatibility types or modify MSQ outside scope; that downstream migration can follow this PR. The direct Quidem module runs used `-Denforcer.skip=true` because the current Quidem dependency graph has a pre-existing protobuf upper-bound conflict (3.19.6 through Confluent versus 3.24.4 through the Google extensions). Part of #13948. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
