FrankChen021 commented on PR #19909: URL: https://github.com/apache/druid/pull/19909#issuecomment-5210287806
Validation evidence for the MSQ processing-helper follow-up: - Replaced all three MSQ-owned `GroupByQueryRunnerTest` consumers with the JUnit 5-safe `GroupByQueryRunnerTestHelper.makeQueryRunnerFactory(objectMapper, config, buffers)` API. - Audited `multi-stage-query` Java sources: no `GroupByQueryRunnerTest` façade references remain. - On a disposable combined validation tree containing PR #19875's processing helper and the related sibling migration changes, `mvn -pl multi-stage-query test-compile -DskipTests -Pskip-static-checks -Dweb.console.skip=true -T1C` passed. - Focused `MSQTaskQueryMakerTest`: 9 tests passed. - Checkstyle: 0 violations. SpotBugs: 0 bugs and 0 errors. Forbidden-API scan: 0 errors. - `MSQCompactionTaskRunTest` reaches test setup but is currently blocked before test bodies by the shared `TaskActionTestKit.before()` initialization (`IllegalStateException` at `MSQCompactionTaskRunTest.setup:217`), with the existing teardown NPE because the executor was never created. No helper compilation or API errors occur. - `git diff --check` passed; the commit changes only the three MSQ test files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
