jaykanakiya commented on code in PR #19704:
URL: https://github.com/apache/druid/pull/19704#discussion_r3810670963
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/DimensionValueSetCollector.java:
##########
Review Comment:
Updated the doc.
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/simulate/EmbeddedDimensionValueSetShardSpecTest.java:
##########
@@ -277,26 +277,24 @@ public void
test_multiDimensionAndMultiValuePartitionDimensionValues()
}
/**
- * Numeric (Long) tracked dimensions are recorded in the shard spec but are
NOT used for pruning: numeric query
- * filters opt out of segment pruning (their getDimensionRangeSet returns
null, since pruning compares values
- * lexicographically), so a numeric equality filter scans every segment even
though each segment declares exactly
- * one numeric value. Queries stay correct; there is simply no pruning
benefit.
- *
- * <p>This is intentional for now. We could either consider extending
pruning to numeric types with type-aware
- * (non-lexicographic) comparison, or (b) reject numeric dimensions outright
when they're declared.
+ * A numeric (LONG) tracked dimension with an explicit {@link
LongDimensionSchema} IS pruned: the broker's
+ * equality/IN/IS NULL channel is type-gated on {@code
dimensionColumnTypes}, which the task stamps only for such a
+ * schema (a LONG stringifies identically on ingest and query, so set
membership is exact). This is exact
+ * set-membership, not a range comparison, so it works even though the
dimension is numeric.
*/
@Test
- public void test_numericDimension_isNotPruned()
Review Comment:
Updated in next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
