FrankChen021 commented on code in PR #19768:
URL: https://github.com/apache/druid/pull/19768#discussion_r3880823624
##########
benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlExpressionBenchmark.java:
##########
@@ -179,7 +179,34 @@ public class SqlExpressionBenchmark extends
SqlBaseQueryBenchmark
"SELECT SUM(ABS(long1 - long4)) FROM expressions",
// 69,70: unary sqrt on double and long inputs (long input exercises the
SIMD widening path)
"SELECT SUM(SQRT(double1)) FROM expressions",
- "SELECT SUM(SQRT(long1)) FROM expressions"
+ "SELECT SUM(SQRT(long1)) FROM expressions",
+ // 71-96: VO_MATHLIB unary ops exposed via SQL and covered by SIMD
dispatch.
+ "SELECT SUM(LN(double1)) FROM expressions",
+ "SELECT SUM(LN(long1)) FROM expressions",
+ "SELECT SUM(EXP(double1)) FROM expressions",
+ "SELECT SUM(EXP(long1)) FROM expressions",
+ "SELECT SUM(LOG10(double1)) FROM expressions",
+ "SELECT SUM(LOG10(long1)) FROM expressions",
+ "SELECT SUM(CBRT(double1)) FROM expressions",
Review Comment:
[P2] CBRT benchmark queries are not plannable
The two new queries call CBRT, but CBRT is not registered in
DruidOperatorTable. These benchmark cases therefore fail during SQL planning
instead of exercising the intended SIMD expression path. Add the operator
conversion/registration or remove the cases until the function is supported by
the planner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
