FrankChen021 commented on code in PR #20555:
URL: https://github.com/apache/druid/pull/20555#discussion_r4240998017


##########
docs/querying/query-context-reference.md:
##########
@@ -43,36 +43,35 @@ Unless otherwise noted, the following parameters apply to 
all query types, and t
 
 |Parameter          |Default                                 | Description     
     |
 
|-------------------|----------------------------------------|----------------------|
-|`timeout`          | `druid.server.http.defaultQueryTimeout`| Query timeout 
in millis, beyond which unfinished queries will be cancelled. 0 timeout means 
`no timeout` (up to the server-side maximum query timeout, 
`druid.server.http.maxQueryTimeout`). To set the default timeout and maximum 
timeout, see [Broker configuration](../configuration/index.md#broker) |
-|`perSegmentTimeout`| `null`                                 | Per-segment 
processing timeout in millis, beyond which unfinished queries will be 
cancelled. Should be ≤ `timeout`. 0 `perSegmentTimeout` means `no per-segment 
timeout`. Generally, a standard default should be O(X seconds). A cluster-wide 
default value for this query context can be specified via 
`druid.query.default.context.perSegmentTimeout`.|
-|`priority`         | The default priority is one of the following: 
<ul><li>Value of `priority` in the query context, if set</li><li>The value of 
the runtime property `druid.query.default.context.priority`, if set and not 
null</li><li>`0` if the priority is not set in the query context or runtime 
properties</li></ul>| Query priority. Queries with higher priority get 
precedence for computational resources.|
-|`lane`             | `null`                                 | Query lane, 
used to control usage limits on classes of queries. See [Broker 
configuration](../configuration/index.md#broker) for more details.|
-|`queryId`          | auto-generated                         | Unique 
identifier given to this query. If a query ID is set or known, this can be used 
to cancel the query |
-|`brokerService`    | `null`                                 | Broker service 
to which this query should be routed. This parameter is honored only by a 
broker selector strategy of type *manual*. See [Router 
strategies](../design/router.md#router-strategies) for more details.|
-|`useCache`         | `true`                                 | Flag indicating 
whether to leverage the query cache for this query. When set to false, it 
disables reading from the query cache for this query. When set to true, Apache 
Druid uses `druid.broker.cache.useCache` or `druid.historical.cache.useCache` 
to determine whether or not to read from the query cache |
-|`populateCache`    | `true`                                 | Flag indicating 
whether to save the results of the query to the query cache. Primarily used for 
debugging. When set to false, it disables saving the results of this query to 
the query cache. When set to true, Druid uses 
`druid.broker.cache.populateCache` or `druid.historical.cache.populateCache` to 
determine whether or not to save the results of this query to the query cache |
+|`timeout`| `druid.server.http.defaultQueryTimeout` | Query timeout in millis, 
beyond which unfinished queries will be cancelled. 0 timeout means `no timeout` 
(up to the server-side maximum query timeout, 
`druid.server.http.maxQueryTimeout`). To set the default timeout and maximum 
timeout, see [Broker configuration](../configuration/index.md#broker).| <!-- 
GENERATED QUERY CONTEXT PARAMETER: timeout -->
+|`perSegmentTimeout`| `null` | Per-segment processing timeout in millis, 
beyond which unfinished queries will be cancelled. Should be ≤ `timeout`. 0 
`perSegmentTimeout` means `no per-segment timeout`. Generally, a standard 
default should be O(X seconds). A cluster-wide default value for this query 
context can be specified via `druid.query.default.context.perSegmentTimeout`.| 
<!-- GENERATED QUERY CONTEXT PARAMETER: perSegmentTimeout -->
+|`priority`| The default priority is one of the following: <ul><li>Value of 
`priority` in the query context, if set</li><li>The value of the runtime 
property `druid.query.default.context.priority`, if set and not 
null</li><li>`0` if the priority is not set in the query context or runtime 
properties</li></ul> | Query priority. Queries with higher priority get 
precedence for computational resources.| <!-- GENERATED QUERY CONTEXT 
PARAMETER: priority -->
+|`lane`| `null` | Query lane, used to control usage limits on classes of 
queries. See [Broker configuration](../configuration/index.md#broker) for more 
details.| <!-- GENERATED QUERY CONTEXT PARAMETER: lane -->
+|`queryId`| auto-generated | Unique identifier given to this query. If a query 
ID is set or known, this can be used to cancel the query.| <!-- GENERATED QUERY 
CONTEXT PARAMETER: queryId -->

Review Comment:
   Reverted in 57c201f5f9. On master only the first dozen rows of this table 
were aligned, and padding doesn't change how the table renders, so the 
generator keeps emitting compact rows.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to