FrankChen021 commented on code in PR #20555:
URL: https://github.com/apache/druid/pull/20555#discussion_r4247881868
##########
processing/src/main/java/org/apache/druid/query/timeseries/TimeseriesQuery.java:
##########
@@ -179,7 +179,7 @@ public String getTimestampResultField()
public boolean isSkipEmptyBuckets()
{
- return context().getBoolean(SKIP_EMPTY_BUCKETS, false);
+ return context().getOrDefault(QueryContextParameters.SKIP_EMPTY_BUCKETS);
Review Comment:
[P2] Preserve public SKIP_EMPTY_BUCKETS compatibility constant
**Finding:** The diff removes the existing public
TimeseriesQuery.SKIP_EMPTY_BUCKETS field while isSkipEmptyBuckets() still
exposes the same user-facing context behavior through the descriptor.
Downstream extensions or callers compiled against that public constant will
fail to compile after upgrading, even though the context key remains valid;
this is a source-compatibility regression caused by the refactor.
**Suggestion:** Retain the field as a deprecated compatibility alias for the
descriptor name while routing internal code through
QueryContextParameters.SKIP_EMPTY_BUCKETS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
