FrankChen021 commented on code in PR #20555:
URL: https://github.com/apache/druid/pull/20555#discussion_r4241607548
##########
processing/src/main/java/org/apache/druid/query/timeseries/TimeseriesQuery.java:
##########
@@ -179,7 +179,7 @@ public String getTimestampResultField()
public boolean isSkipEmptyBuckets()
{
- return context().getBoolean(SKIP_EMPTY_BUCKETS, false);
+ return context().getOrDefault(QueryContextParameters.SKIP_EMPTY_BUCKETS);
Review Comment:
[P2] Preserve public skip-empty-buckets constant
**Finding:** This refactor removes the existing public
`TimeseriesQuery.SKIP_EMPTY_BUCKETS` field. Downstream extensions and callers
that use this established constant to populate query context maps will now fail
to compile, even though the context key and runtime behavior are unchanged.
**Suggestion:** Retain a deprecated compatibility alias with the same
`skipEmptyBuckets` value while keeping internal reads and writes on
`QueryContextParameters.SKIP_EMPTY_BUCKETS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
