gianm commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-476861755 > Reconcile terminology and method naming to 'used/unused segments' This looks related and somewhat conflicting with the terminology discussion on #7233, where initial confusion over the meaning of `is_published` led to a suggestion of creating a new term "active". What do you think about the suggestion on https://github.com/apache/incubator-druid/issues/7233#issuecomment-474639633? I think if we go with where 7233 is going, the term for "used segments" would be "published segments". Fwiw, one reason I like this term because it lends itself well to being used as verbs in the following way: - A task would first _push_ a segment to deep storage, and then _publish_ it to the metadata store. - When a segment is dropped it is _unpublished_ from the metadata store by setting `used = false`. > Don't use terms 'enable/disable data source' Yeah, I definitely also believe these terms are not great, and are confusing for the reasons you mention. Here the "publish" and "unpublish" terms are a bit awkward though. It doesn't sound right to say "publish all segments in a datasource" instead of "enable a datasource". "Mark used" or "activate" sounds better. I'm not sure how to reconcile this with the fact that I _do_ think "publish" sounds good & intuitive as a verb in the case where a task is initially writing a segment record to the metadata store. Maybe this is how: - Tasks "publish" segments when they insert records into the metadata store with `used = true` (upon creation of the segment) - Later on if we drop a segment, we do that by "marking it unused" or, potentially, "deactivating" it. - If we re-enable a segment, we do that by "marking it used", or, potentially, "activating" it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
