gianm commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-477382296 > I'm not sure that a column in sys.segments and the internal codebase concept (currently "used segments") are the same thing. I think it's best if they are the same thing, since the point of system tables like `sys.segments` is to help cluster operators introspect into the state of the system using a familiar SQL style API. (So they don't have to go digging through metadata store, ZK, various Druid APIs to get a picture of what's going on.) If it turns out that for some reason, they _can't_ be the same thing, then it makes sense to use two different names. But if they could be the same thing then it's probably best to do that.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
