gianm commented on issue #7306: Reconcile terminology and method naming to 
'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments
URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-477377099
 
 
   > I think it makes sense to keep terminology between virtual Druid's SQL 
table `sys.segments` and metadata store (and therefore the remaining of the 
codebase) separate.
   
   I don't think we need to be dogmatic about it. But if possible, it benefits 
everyone (users & developers alike) to have consistent terminology across the 
entire system.
   
   > Can `used` be renamed? Or not, because it's a column in the database that 
needs to remain compatible?
   
   Do you mean in the metadata store? I don't think it could be, since we don't 
have a way to automatically migrate already-existing metadata stores that use 
the name `used`. But we could decide we want to call the concept something else 
_in general_, and just keep a note that for legacy reasons, the metadata store 
uses the old name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to