amaechler opened a new pull request, #20796: URL: https://github.com/apache/druid/pull/20796
### Description This PR adds an ASF config entry so every PR into `master` requires at least one approval. Our [community page](https://druid.apache.org/community/) already says that every pull request needs one approval (+1) from a committer. This change enforces that on GitHub too. #### Require one approving review on `master` Adds `required_approving_review_count: 1` for `master` in `.asf.yaml`. GitHub only counts approvals from people with write access, which for an ASF repo means committers. Authors can't approve their own PRs, so a committer's PR needs a second committer. `.asf.yaml` can't exempt committers from the rule, so in a hurry the fallback is a quick approval from another committer (or an Infra ticket in a real emergency). The rule only covers `master`; release branches such as `39.0.0` still allow merging without an approval. #### What should we do with the old `0.x` branches? Besides `master`, ten pre-ASF branches (`0.6.x` through `0.9.1`) are protected today. Once `protected_branches` is set, ASF Infra removes protection from any branch not listed there, so these branches will no longer be protected. If anyone wants to keep that protection, I can list them in `.asf.yaml` with an empty `{}` entry each. <hr> This PR has: - [x] been self-reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
