amaechler commented on code in PR #20796: URL: https://github.com/apache/druid/pull/20796#discussion_r4429990524
########## .asf.yaml: ########## @@ -1,9 +1,24 @@ -# note: documentation can be found here https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features +# note: documentation can be found here https://github.com/apache/infrastructure-asfyaml/blob/main/README.md github: description: 'Apache Druid: a high performance real-time analytics database.' homepage: https://druid.apache.org/ + rulesets: + - name: "Default Branch Protection" Review Comment: If you leave out `type`, ASF's `.asf.yaml` tooling treats the ruleset as a branch ruleset ([source](https://github.com/apache/infrastructure-asfyaml/blob/604c99e29d82b4baf9836b5cb6db99f034e910cd/asfyaml/feature/github/rulesets.py#L465)). The live ruleset confirms it: "Default Branch Protection" was created from this commit as a branch ruleset covering `master` and the release branches. The "Require review" ruleset did fail, but for a different reason: GitHub doesn't allow a secret team like `druid-committers` to bypass a ruleset. #20804 fixed that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
