FrankChen021 commented on code in PR #20796: URL: https://github.com/apache/druid/pull/20796#discussion_r4429464765
########## .asf.yaml: ########## @@ -1,9 +1,24 @@ -# note: documentation can be found here https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features +# note: documentation can be found here https://github.com/apache/infrastructure-asfyaml/blob/main/README.md github: description: 'Apache Druid: a high performance real-time analytics database.' homepage: https://druid.apache.org/ + rulesets: + - name: "Default Branch Protection" Review Comment: [P1] Declare both rulesets as branch rulesets **Finding:** The ASF convenience syntax expects each ruleset to declare its target type, and its documented default-branch behavior is conditional on type: branch. This diff removes type: branch from both entries, leaving neither entry with a raw target or conditions discriminator; the ASF processor may reject or fail to reconcile them, leaving the required approval and default/release branch protections unenforced. **Suggestion:** Add the explicit type: branch discriminator to both convenience entries and validate the configuration through ASF's ruleset validation path before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
