egor-ryashin commented on a change in pull request #7306: Reconcile terminology
and method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270213438
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -48,21 +49,21 @@
{
public static final String CONFIG_KEY = "coordinator.config";
- private final long millisToWaitBeforeDeleting;
+ private final long
millisLagSinceCoordinatorBecomesLeaderBeforeCanMarkAsUnusedOvershadowedSegments;
private final long mergeBytesLimit;
private final int mergeSegmentsLimit;
private final int maxSegmentsToMove;
private final int replicantLifetime;
private final int replicationThrottleLimit;
private final int balancerComputeThreads;
private final boolean emitBalancingStats;
- private final boolean killAllDataSources;
- private final Set<String> killableDataSources;
+ private final boolean killUnusedSegmentsInAllDataSources;
+ private final Set<String> specificDataSourcesToKillUnusedSegmentsIn;
private final Set<String> decommissioningNodes;
private final int decommissioningMaxPercentOfMaxSegmentsToMove;
- // The pending segments of the dataSources in this list are not killed.
- private final Set<String> protectedPendingSegmentDatasources;
+ /** Stale pending segments belonging to the data sources in this list are
not killed (they are "protected"). */
+ private final Set<String> dataSourcesToNotKillStalePendingSegmentsIn;
Review comment:
A link to the explanation of pending segments would be welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
