egor-ryashin commented on a change in pull request #7306: Reconcile terminology
and method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270215150
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -201,29 +215,29 @@ public int getBalancerComputeThreads()
}
/**
- * List of dataSources for which kill tasks are sent in
- * {@link
org.apache.druid.server.coordinator.helper.DruidCoordinatorSegmentKiller}.
+ * List of specific data sources for which kill tasks are sent in
+ * {@link DruidCoordinatorUnusedSegmentsKiller}.
*/
@JsonProperty("killDataSourceWhitelist")
- public Set<String> getKillableDataSources()
+ public Set<String> getSpecificDataSourcesToKillUnusedSegmentsIn()
{
- return killableDataSources;
+ return specificDataSourcesToKillUnusedSegmentsIn;
}
@JsonProperty
- public boolean isKillAllDataSources()
+ public boolean isKillUnusedSegmentsInAllDataSources()
{
- return killAllDataSources;
+ return killUnusedSegmentsInAllDataSources;
}
/**
* List of dataSources for which pendingSegments are NOT cleaned up
- * in {@link DruidCoordinatorCleanupPendingSegments}.
+ * in {@link DruidCoordinatorKillStalePendingSegments}.
*/
- @JsonProperty
- public Set<String> getProtectedPendingSegmentDatasources()
+ @JsonProperty("killPendingSegmentsSkipList")
Review comment:
Could you elaborate `stale` in the method description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
