egor-ryashin commented on a change in pull request #7306: Reconcile terminology
and method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270214182
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -74,37 +75,48 @@
@JsonCreator
public CoordinatorDynamicConfig(
- @JsonProperty("millisToWaitBeforeDeleting") long
millisToWaitBeforeDeleting,
+ // Keeping the legacy 'millisToWaitBeforeDeleting' property name for
backward compatibility. When the project is
+ // updated to Jackson 2.9 it could be changed, see
https://github.com/apache/incubator-druid/issues/7152
+ @JsonProperty("millisToWaitBeforeDeleting")
+ long
millisLagSinceCoordinatorBecomesLeaderBeforeCanMarkAsUnusedOvershadowedSegments,
@JsonProperty("mergeBytesLimit") long mergeBytesLimit,
@JsonProperty("mergeSegmentsLimit") int mergeSegmentsLimit,
@JsonProperty("maxSegmentsToMove") int maxSegmentsToMove,
@JsonProperty("replicantLifetime") int replicantLifetime,
@JsonProperty("replicationThrottleLimit") int replicationThrottleLimit,
@JsonProperty("balancerComputeThreads") int balancerComputeThreads,
@JsonProperty("emitBalancingStats") boolean emitBalancingStats,
-
- // Type is Object here so that we can support both string and list as
- // coordinator console can not send array of strings in the update
request.
- // See https://github.com/apache/incubator-druid/issues/3055
- @JsonProperty("killDataSourceWhitelist") Object killableDataSources,
- @JsonProperty("killAllDataSources") boolean killAllDataSources,
- @JsonProperty("killPendingSegmentsSkipList") Object
protectedPendingSegmentDatasources,
+ // Type is Object here so that we can support both string and list as
Coordinator console can not send array of
+ // strings in the update request. See
https://github.com/apache/incubator-druid/issues/3055.
+ // Keeping the legacy 'killDataSourceWhitelist' property name for
backward compatibility. When the project is
+ // updated to Jackson 2.9 it could be changed, see
https://github.com/apache/incubator-druid/issues/7152
+ @JsonProperty("killDataSourceWhitelist") Object
specificDataSourcesToKillUnusedSegmentsIn,
+ // Keeping the legacy 'killAllDataSources' property name for backward
compatibility. When the project is
+ // updated to Jackson 2.9 it could be changed, see
https://github.com/apache/incubator-druid/issues/7152
+ @JsonProperty("killAllDataSources") boolean
killUnusedSegmentsInAllDataSources,
Review comment:
Could you elaborate `kill` in the method description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
