gianm commented on a change in pull request #7325: Fix result-level cache for 
queries
URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r274167915
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/druid/query/groupby/having/GreaterThanHavingSpec.java
 ##########
 @@ -119,4 +123,36 @@ public String toString()
     sb.append('}');
     return sb.toString();
   }
+
+  @Override
+  public byte[] getCacheKey()
+  {
+    try {
+      final ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
 
 Review comment:
   Would CacheKeyBuilder work for this (and similar method)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to