gianm commented on a change in pull request #7325: Fix result-level cache for
queries
URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276420977
##########
File path:
processing/src/main/java/org/apache/druid/query/metadata/SegmentMetadataQueryQueryToolChest.java
##########
@@ -194,6 +194,12 @@ public boolean isCacheable(SegmentMetadataQuery query,
boolean willMergeRunners)
.array();
}
+ @Override
+ public byte[] computeResultLevelCacheKey(SegmentMetadataQuery query)
+ {
+ return computeCacheKey(query);
Review comment:
This also needs to include "merge" and "lenientAggregatorMerge". They're not
part of the segment-level cache key, but they should be part of the
result-level key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
