gianm commented on a change in pull request #7325: Fix result-level cache for
queries
URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276423783
##########
File path:
server/src/main/java/org/apache/druid/client/CachingClusteredClient.java
##########
@@ -385,6 +385,7 @@ private String computeCurrentEtag(final
Set<ServerToSegment> segments, @Nullable
break;
}
hasher.putString(p.getServer().getSegment().getId().toString(),
StandardCharsets.UTF_8);
+ hasher.putString(p.rhs.getInterval().toString(),
StandardCharsets.UTF_8);
Review comment:
Comment here would be nice, explaining that this interval is the query
interval, not the segment interval, and it's important for it to be part of the
cache key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
