jon-wei commented on a change in pull request #7425: Add is_overshadowed column
to sys.segments table
URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r274728196
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##########
@@ -295,6 +302,7 @@ public TableType getJdbcTableType()
val.getValue().isPublished(),
val.getValue().isAvailable(),
val.getValue().isRealtime(),
+ AVAILABLE_IS_OVERSHADOWED_VALUE,
Review comment:
i think this should have a comment that this assumes unpublished segments
are never overshadowed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
