jon-wei commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r274727857
########## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ########## @@ -92,6 +93,9 @@ private static final String SERVER_SEGMENTS_TABLE = "server_segments"; private static final String TASKS_TABLE = "tasks"; + private static final long AVAILABLE_IS_OVERSHADOWED_VALUE = 0L; Review comment: hm, if we use these, I think `IS_OVERSHADOWED_FALSE` would be clearer, and it should have `IS_OVERSHADOWED_TRUE` as well ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
