dclim commented on a change in pull request #7428: Add errors and state to
stream supervisor status API endpoint
URL: https://github.com/apache/incubator-druid/pull/7428#discussion_r278326267
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
##########
@@ -1024,7 +1034,9 @@ public void runInternal()
throws ExecutionException, InterruptedException, TimeoutException,
JsonProcessingException
{
possiblyRegisterListener();
+
stateManager.setState(SeekableStreamSupervisorStateManager.State.CONNECTING_TO_STREAM);
Review comment:
How about `maybeSetState` instead of `setState`, since the majority of the
time the state doesn't actually change, but the method name gives the
impression it cycles through the states on every run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
