dclim commented on a change in pull request #7428: Add errors and state to
stream supervisor status API endpoint
URL: https://github.com/apache/incubator-druid/pull/7428#discussion_r278338425
##########
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java
##########
@@ -671,16 +688,22 @@ private void
filterBufferAndResetFetchRunnable(Set<StreamPartition<String>> part
private String getSequenceNumberInternal(StreamPartition<String> partition,
ShardIteratorType iteratorEnum)
{
- String shardIterator = null;
+ String shardIterator;
try {
shardIterator = kinesis.getShardIterator(
partition.getStream(),
partition.getPartitionId(),
iteratorEnum.toString()
).getShardIterator();
}
+ catch (LimitExceededException | ProvisionedThroughputExceededException |
ResourceInUseException e) {
+ throw new TransientStreamException(e);
+ }
catch (ResourceNotFoundException e) {
- log.warn(e, "Caught ResourceNotFoundException while getting
shardIterator");
+ throw new PossiblyTransientStreamException(e);
+ }
+ catch (AmazonKinesisException e) {
+ throw new NonTransientStreamException(e);
}
return getSequenceNumberInternal(partition, shardIterator);
Review comment:
Does the call to `kinesis.getShardIterator()` in `seekInternal()` need to be
wrapped too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
