dclim commented on a change in pull request #7428: Add errors and state to stream supervisor status API endpoint URL: https://github.com/apache/incubator-druid/pull/7428#discussion_r278323827
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorReportPayload.java ########## @@ -44,6 +45,8 @@ private final Long aggregateLag; private final DateTime offsetsLastUpdated; private final boolean suspended; + private final SeekableStreamSupervisorStateManager.State state; + private final Queue<SeekableStreamSupervisorStateManager.ExceptionEvent> recentErrors; Review comment: minor: I think typically we use `List` rather than `Queue` if there's no particular reason for it to be a queue. `ExceptionEventStore.getRecentEvents()` should probably return something more common like`List` or `Collection`. Also while we're at it, it should probably copy the data into an immutable data type instead of passing the underlying `ConcurrentLinkedQueue` around to avoid accidental modification. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
