clintropolis commented on a change in pull request #7769: SQL: Allow
select-sort-project query shapes.
URL: https://github.com/apache/incubator-druid/pull/7769#discussion_r287921667
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/rel/VirtualColumnRegistry.java
##########
@@ -32,52 +32,38 @@
import java.util.TreeSet;
/**
- * Wraps a {@link RowSignature} and provides facilities to re-use {@link
VirtualColumn} definitions for dimensions,
- * filters, and filtered aggregators while constructing a {@link DruidQuery}
+ * Provides facilities to create and re-use {@link VirtualColumn} definitions
for dimensions, filters, and filtered
+ * aggregators while constructing a {@link DruidQuery}.
*/
-public class DruidQuerySignature
+public class VirtualColumnRegistry
Review comment:
Hmm, so the reason I didn't initially name this something specific to
virtual columns was that I intended to follow up that PR with another to try
and consolidate all of the aggregate 'create or re-use' logic that is sprinkled
around in all of the aggregator operator implementations, in the same way that
this is currently doing with virtual columns, and use this type as a sort of
row signature accumulator to use to keep state while building a query. The
other reason for using it to represent the 'query shape' is, as I'm sure you
noticed, to avoid passing around 2 semi-related arguments everywhere.
I however, got a bit side-tracked and haven't got around to the follow-up
yet, so I suppose I could always rename this to something else if I ever get
around to it. I'm not sure it would make sense to use in quite the same way
after the changes in this PR to split back out the row signature and pass it
around as well. Note that I'm not trying to dispute this change, just giving
some context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
