clintropolis commented on a change in pull request #7769: SQL: Allow
select-sort-project query shapes.
URL: https://github.com/apache/incubator-druid/pull/7769#discussion_r287990647
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/rel/VirtualColumnRegistry.java
##########
@@ -32,52 +32,38 @@
import java.util.TreeSet;
/**
- * Wraps a {@link RowSignature} and provides facilities to re-use {@link
VirtualColumn} definitions for dimensions,
- * filters, and filtered aggregators while constructing a {@link DruidQuery}
+ * Provides facilities to create and re-use {@link VirtualColumn} definitions
for dimensions, filters, and filtered
+ * aggregators while constructing a {@link DruidQuery}.
*/
-public class DruidQuerySignature
+public class VirtualColumnRegistry
Review comment:
Yeah I agree the change makes more sense in this refactored world, that i
think now also more accurately reflects reality, but where the stages are less
obviously split into 'pre' and 'post' stuff. Like I said, not disputing the
changes here 😅. It seems like it would be a bit messy in a couple other places
too if you had to treat it as potentially in either 'mutable' or 'immutable'
context depending on the type query, so I'm on board.
I ever find the spare time, I will still probably look into if it's possible
to consolidate the agg re-use boilerplate code into what is now
`VirtualColumnRegistry` to help simplify sql agg implementations where possible
though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
