clintropolis commented on a change in pull request #7547: Add support minor
compaction with segment locking
URL: https://github.com/apache/incubator-druid/pull/7547#discussion_r298815228
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java
##########
@@ -572,7 +638,7 @@ private static boolean isGuaranteedRollup(IndexIOConfig
ioConfig, IndexTuningCon
*
* @return generated {@link ShardSpecs} representing a map of intervals and
corresponding shard specs
*/
- private ShardSpecs determineShardSpecs(
+ private Map<Interval, Pair<ShardSpecFactory, Integer>> determineShardSpecs(
Review comment:
Hmm, the javadoc link on the return type is no longer correct here (and a
couple of other places). However, there might be enough `Map<Interval,
Pair<ShardSpecFactory, Integer>>` to consider capturing it into a type similar
to `ShardSpecs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
