clintropolis commented on a change in pull request #7547: Add support minor
compaction with segment locking
URL: https://github.com/apache/incubator-druid/pull/7547#discussion_r306669126
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java
##########
@@ -997,10 +938,11 @@ private TaskStatus generateAndPublishSegments(
final SegmentsAndMetadata pushed = driver.pushAllAndClear(pushTimeout);
log.info("Pushed segments[%s]", pushed.getSegments());
- final SegmentsAndMetadata published = awaitPublish(
- driver.publishAll(publisher),
- pushTimeout
- );
+ // Probably we can publish atomicUpdateGroup along with segments.
+ final Set<DataSegment> inputSegments = isUseSegmentLock()
+ ?
getSegmentLockHelper().getLockedExistingSegments()
+ : null;
+ final SegmentsAndMetadata published =
awaitPublish(driver.publishAll(inputSegments, publisher), pushTimeout);
Review comment:
is `driver.publishAll` going to be sad if `inputSegments` is null because
not using segment lock? could you explain this a bit better in comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
