clintropolis commented on a change in pull request #7547: Add support minor
compaction with segment locking
URL: https://github.com/apache/incubator-druid/pull/7547#discussion_r299208501
##########
File path:
benchmarks/src/main/java/org/apache/druid/server/coordinator/NewestSegmentFirstPolicyBenchmark.java
##########
@@ -127,7 +127,7 @@ public void setup()
0,
segmentSizeBytes
);
- timeline.add(segment.getInterval(), segment.getVersion(),
shardSpec.createChunk(segment));
+ timeline.add(segment.getInterval(), segment.getMajorVersion(),
shardSpec.createChunk(segment));
Review comment:
After a few hacks at reviewing this PR, I'm starting to wonder if renaming
`getVersion` to `getMajorVersion` worth all the noise it causes in this change.
Like I think it's maybe still obvious that `getVersion` is .. more major than
`getMinorVersion`? Thoughts? Am I missing a reason that this _needs_ to be
renamed?
It might dramatically reduce the footprint of this PR, since a lot of the
changes are to this method call. If you really prefer it, maybe it would be
better to rename it in a follow-up PR that just has that change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
